fix: Resolves failing tests when CERTIFICATE_LINKEDIN setting is configured#37437
fix: Resolves failing tests when CERTIFICATE_LINKEDIN setting is configured#37437deborahgu merged 1 commit intoopenedx:masterfrom
Conversation
openedx-webhooks
added
the
open-source-contribution
|
Thanks for the pull request, @haftamuk! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
haftamuk
changed the title
haftamuk
force-pushed
the
ESHE-37428
branch
4 times, most recently
from
9d75af6 to
2c4fbe6
Compare
mphilbrick211
added
the
needs test run
mphilbrick211
moved this from Needs Triage
to Needs Tests Run or CLA Signed
in Contributions
deborahgu
left a comment
deborahgu
left a comment
There was a problem hiding this comment.
one nit here, also, could you resolve the conflicts?
haftamuk
force-pushed
the
ESHE-37428
branch
2 times, most recently
from
5fe7110 to
c6f0608
Compare
…gured at common.py openedx#37428 In order to be able to share course certificate to LinkedIn, configure SOCIAL_SHARING_SETTINGS with a value True for CERTIFICATE_LINKEDIN entry. The setting is not available by default, but when used there were failing tests and this change ensures all tests pass. Fixes: openedx#37428 (comment)
mphilbrick211
removed
the
needs test run
mphilbrick211
moved this from Needs Tests Run or CLA Signed
to Ready for Review
in Contributions
|
@deborahgu this is all set. Thanks! |
Hi @deborahgu - are you able to take a look for us? |
github-project-automation
bot
moved this from Ready for Review
to Done
in Contributions
…gured at common.py openedx#37428 (openedx#37437) In order to be able to share course certificate to LinkedIn, configure SOCIAL_SHARING_SETTINGS with a value True for CERTIFICATE_LINKEDIN entry. The setting is not available by default, but when used there were failing tests and this change ensures all tests pass. Fixes: openedx#37428 (comment)
4 participants
In order to be able to share course certificate to LinkedIn, configure SOCIAL_SHARING_SETTINGS with a value True for CERTIFICATE_LINKEDIN entry. The setting is not available by default, but when used there were failing tests and this change ensures all tests pass.
Fixes: #37428 (comment)
Testing instructions
Change configuration value of CERTIFICATE_LINKEDIN to True at /lms/envs/common.py and cms/envs/common.py
run
python -Wd -m pytest -p no:randomly --ds=lms.envs.test common/djangoapps/student/tests/See all tests should pass
Change configuration value of CERTIFICATE_LINKEDIN to False at /lms/envs/common.py and cms/envs/common.py
run
python -Wd -m pytest -p no:randomly --ds=lms.envs.test common/djangoapps/student/tests/See all tests should pass